Refactor it!

Now this is a great initiative! Billy McCafferty is doing a weekly contest where he uploads a Visual Studio 2005 solution of a C# project with a specific code smell. You must refactor the solution so that the code smell is removed and so it still passes the supplied unit tests. Winners are randomly drawn by his two year old daughter, because he doesn’t trust the randomness of Math.Random. 🙂 I think the initiative is cool because people will hopefully learn what refactorings are about. I hope he’ll post some of the best solutions and that the winner will get a long review post where Billy will explain all the refactorings that took place.

Refactoring has been widely adopted as a vital technique for producing high quality software.  It is important that we each embrace this practice into our development work.  This contest will serve to present an overview of common smells found within code and discuss techniques to correct those smells for creating better software.

The first challenge is already online for a few days. Read info on Refactor It! and the first challenge here. I’ve taken a look at the code and there is are some beautiful codesmells in there. This is code that could’ve been extracted from a lot of applications that are currently in production, maintained by developers who have to study the code to understand it. The refactorings should make a lot of sense in there. This could also be a great way to learn Refactor! Pro by DevExpress, the tool to use for this kind of stuff.

Oh, Alex, sorry mate, but the tests are written for NUnit. Of course I immediately ran NCover over it and NCoverExplorer produced this result:

There’s one line of code that throws an error when you pass in a null value into the method. Meaning this probably wasn’t written using Test-Driven Development. Not the worst case, but it would be nice to show people how good the tests could be when TDD was used. Besides that, I again have to say I love the initiative and will keep an eye out for the results.

Technorati tags: , ,

You may also like...

1 Response

  1. Jean-Paul Smit says:

    Interesting contest.
    About the refactorings Billy mentions, I found the following useful URL:

    http://www.refactoring.com/catalog/

Click on a tab to select how you'd like to leave your comment

Leave a Reply

Your email address will not be published. Required fields are marked *

This site uses Akismet to reduce spam. Learn how your comment data is processed.